Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cache storeV2 #58

Merged
merged 5 commits into from
Jul 25, 2024
Merged

feat: use cache storeV2 #58

merged 5 commits into from
Jul 25, 2024

Conversation

Cammisuli
Copy link
Member

No description provided.

@Cammisuli Cammisuli changed the title fix: do not include branch name when saving cache feat: use cache storeV2 Jul 3, 2024
@Cammisuli Cammisuli merged commit 918e5d6 into main Jul 25, 2024
1 check passed
@Cammisuli Cammisuli deleted the cache_key_changes branch July 25, 2024 14:03
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
new StoreRequest({
key: `${currentBranch}-${key}`,
key,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cammisuli Is key correct? I'm seeing store v2 keeps failing to find cache from base-branch.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I should have set base_branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants